Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

default_timeout not passed properly from SASLMemcachedCache.__init__() to MemcachedCache.__init__() #186

Closed
sonologic opened this issue Jul 30, 2020 · 0 comments · Fixed by #187
Closed

default_timeout not passed properly from SASLMemcachedCache.__init__() to MemcachedCache.__init__() #186

sonologic opened this issue Jul 30, 2020 · 0 comments · Fixed by #187

Comments

@sonologic
Copy link
Contributor

The offending line:

https://github.com/sh4nks/flask-caching/blob/5eef6738430a6887fce03552cb2438501e3dc741/flask_caching/backends/memcache.py#L236

I believe this should be:

super(SASLMemcachedCache, self).__init__(default_timeout=default_timeout)

Due to this the setting for CACHE_DEFAULT_TIMEOUT is ignored when CACHE_TYPE is saslmemcached.
@sonologic sonologic mentioned this issue Jul 30, 2020
Merged
@sonologic sonologic changed the title default_timout not passed properly from SASLMemcachedCache.__init__() to MemcachedCache.__init__() default_timeout not passed properly from SASLMemcachedCache.__init__() to MemcachedCache.__init__() Jul 30, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SASLMemcachedCache: properly pass default_timeout to super constructor sonologic/flask-caching
1 participant
@sonologic