Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always set csrf_cookie if the user authenticated with remember_token #234

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

Kishi85
Copy link
Contributor

@Kishi85 Kishi85 commented Dec 10, 2019

Fixes #232

A test case is also added to make sure the behavior is as expected from now on.

The has_remember_cookie part is the same as what Flask-Login uses to check whether to do a remember cookie login or not (so feel free to check the implementation of login_manager for that).

@Kishi85 Kishi85 force-pushed the csrf-cookie-on-remember-login branch from 7ad2fbd to 2080946 Compare December 10, 2019 21:00
@jwag956 jwag956 merged commit 442c0a4 into pallets-eco:master Dec 11, 2019
@Kishi85 Kishi85 deleted the csrf-cookie-on-remember-login branch December 11, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

CSRF cookie not set on remembered login
2 participants