Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Python 3.x support #71

Open
KeNaCo opened this issue Jan 2, 2016 · 4 comments
Open

Python 3.x support #71

KeNaCo opened this issue Jan 2, 2016 · 4 comments

Comments

@KeNaCo
Copy link

KeNaCo commented Jan 2, 2016

urlparse is renamed to urllib.parse in python 3.x
I assume you only support 2.x versions, is there any plans for 3.x compatibility?

I start some work to add python 3.x support. If someone else do same thing please let me know, we can cooperate maybe 😄 .

@KeNaCo KeNaCo changed the title Python 3 - urlparse Python 3.x support Jan 4, 2016
@KeNaCo
Copy link
Author

KeNaCo commented Jan 15, 2016

Ok, if someone need py3 working version, please check my py3 branch. For now waititg for python-twitter update to new version, aslo with py3 support. Then I merge it to my development branch.

@KeNaCo KeNaCo closed this as completed Jan 15, 2016
@KeNaCo KeNaCo reopened this Jan 16, 2016
@KeNaCo KeNaCo mentioned this issue Jan 25, 2016
@exhuma
Copy link

exhuma commented Mar 1, 2016

I just looked at your PR. That's a lot of changes for py3 support. I've only identified two incompatibilities (urlparse and iteritems in utils.py).

Your PR also contains a lot of whitespace fixes which have nothing to do with py3 support.

Nevertheless, I see that the PR is "closed". But I don't see the changes in the develop branch. Has it been successfully merged? Or was this change abandoned?

@KeNaCo
Copy link
Author

KeNaCo commented Mar 2, 2016

Ok, so whole story is I start to use this plugin in my other project. Which is in python 3. So I found bug and fix it. But then I found other bugs like broken tests, no flask factory pattern support... so I fix it and stack it in that 1.6.3.dev1 PR. By the time @mattupstate claim that this lib is no more maintained.. I ask what to do to be maintainer, but no answer. So I close PRs and now I only work on it in my forked repo.

@KeNaCo
Copy link
Author

KeNaCo commented Mar 3, 2016

But if you or someone will check my work and give me some feedback, I can reopen/write issues and send PM step by step again.. I just won't do something and nobody cares..

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants