New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apply_driver_hacks: dialect+driver URI syntax fails #48

Closed

lassic opened this issue Aug 28, 2011 · 0 comments

lassic commented Aug 28, 2011

(sqlalchemy.py)
def apply_driver_hacks(self, app, info, options):
if info.drivername == 'mysql':

This fails to recognize URIs like 'mysql+pymsql://...'
I guess it should check 'contains mysql' or even a regex check like '^mysql+'.

Thanks.

e-dard mentioned this issue

Fix apply_driver_hacks for various mysql drivers, rather than just the default driver. #96

Merged

mitsuhiko closed this as completed in

cf659f3

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.