Add signing of cache values. #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThiefMaster
reviewed
Aug 13, 2021
setup.cfg
Outdated
| @@ -29,6 +29,8 @@ packages = find: | |||
| package_dir = = src | |||
| include_package_data = true | |||
| python_requires = >= 3.6 | |||
| install_requires = | |||
| itsdangerous ~= 2.0.0 | |||
There was a problem hiding this comment.
I think this also rejects 2.1 even though that's not expected to contain breaking changes. I'd use ~= 2.0 to allow anything <3...
There was a problem hiding this comment.
Yes, you are right: https://www.python.org/dev/peps/pep-0440/#compatible-release, fixed with 4f3dc7d
| self.default_timeout = default_timeout | ||
| if secret_key is not None: | ||
| self.__signed_serializer = itsdangerous.Serializer( |
There was a problem hiding this comment.
Why double-underscore names? That makes subclassing less convenient.
There was a problem hiding this comment.
Subclass are only supposed to access _dump/load(s), but sure, I can remove a single underscore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to sign the stored cache values. Most classes now accept the extra argument
secret_keyfor signing cache values with this key. itsdangerous is used for signing.The "SimpleCache" and "MemcachedCache" classes do not accept the new
secret_keykwarg - the simple does not have any use, and various memcached client libraries already use pickle internally for serialization.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed. --> let's see what CI/CD say. I unfortunately did not have redis, uwsgi and memcached installed...