Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use pkg_resources for --version #1488

Closed
davidism opened this issue Mar 6, 2020 · 0 comments
Closed

Don't use pkg_resources for --version #1488

davidism opened this issue Mar 6, 2020 · 0 comments
Labels
good first issue
Milestone
8.0.0

Comments

@davidism
Copy link
Member

davidism commented Mar 6, 2020

The --version option uses pkg_resources to get the version information from the distribution metadata. Use importlib_metadata instead, but don't make it a dependency. When creating the decorator, issue a warning if a version is not given and importlib_metadata is not installed.
@davidism davidism added this to the 8.0 milestone Mar 6, 2020
@0x1za 0x1za mentioned this issue Jun 10, 2020
Merged
@davidism davidism closed this as completed Jul 1, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
1 participant
@davidism