-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Click 8.0 does not support mypy's no_implicit_reexport #1879
Comments
Please provide a minimal reproducible example. It's not clear that this is an issue with Click vs MyPy vs typeshed. |
I'll work on that... As another datapoint, I've asked about this on the Mypy Gitter and got this response:
|
# foo.py
import click
def foo(option: click.Option) -> None:
pass python3 -m venv venv
venv/bin/pip install --upgrade 'click>=8' mypy
venv/bin/mypy --strict foo.py
|
I've updated the title because that repro 鈽濓笍 doesn't seem to happen without |
You'll probably want to report this to mypy, as I have absolutely no idea how to address it. Need some typing experts to look at it. |
This is about the That said this seems a bit too strict in this case, so maybe mypy should change its behavior to be more permissive here. |
Thanks @JelleZijlstra, I'll close this for now as it seems to be a project config issue, not an issue with our types. |
Workaround is to pin |
This is a configuration you add to your own project, not something we will change.
|
Looks like 8.0.0 started shipping type annotations (yay!): 0103c95
Something doesn't seem to be clicking (no pun intended 馃榿) with
mypy
, though:Anyone else seeing this or know what's up?
The text was updated successfully, but these errors were encountered: