Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of GitBash is not detected correctly #2521

Closed
a-ludi opened this issue May 25, 2023 · 1 comment · May be fixed by a-ludi/click#1
Closed

Version of GitBash is not detected correctly #2521

a-ludi opened this issue May 25, 2023 · 1 comment · May be fixed by a-ludi/click#1

Comments

@a-ludi
Copy link

a-ludi commented May 25, 2023

Shell version detection did not work if BASH_VERSION included syntactically relevant symbols, e.g. parenthesis:

/bin/bash: -c: line 0: syntax error near unexpected token `('
/bin/bash: -c: line 0: `echo 5.0.17(1)-release'

I do not know how to replicate the bug, really. You would have to trick Bash into spitting out a problematic version string. Mine does that of its own accord.

It should detect the version as major=5 and minor=0.

Environment:

  • Python version: irrelevant
  • Click version: 8.0.3
@davidism
Copy link
Member

Duplicate of #2461

@davidism davidism marked this as a duplicate of #2461 May 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants