format_filename replaces invalid bytes
#2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Names are converted to bytes, handling surrogate escapes, then
invalid bytes are replaced.
- Remove _compat.get_filesystem_encoding, sys.getfilesystemencoding
does not return None since Python 3.2.
- Use format_filename in more places.
- Test that surrogate escapes are not present in error messages.
- Add information about when surrogate escapes are safe for output to
format_filename docstring.
- Move supports_symlinks check next to test instead of importing.
- Improve click.Path documentation about str/bytes handling.
davidism
force-pushed
the
format_filename-errors
branch
from
45567ea
to
43c2e7f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continues #2487 by @RazerM
fixes #2395
_compat.get_filesystem_encoding,sys.getfilesystemencodingdoes not returnNonesince Python 3.2.format_filenamein more places.format_filenamedocstring.supports_symlinkscheck next to test instead of importing.click.Pathdocumentation about str/bytes handling.