Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bind reflection #1052

Closed
wants to merge 3 commits into from
Closed

Conversation

subnix
Copy link

@subnix subnix commented May 16, 2022

Reflection is broken in extra binds, because of bind_key is not set for reflected tables.
Also sqlalchemy>=0.9.2 is required. So fix may be backported to 2.x branch if we can drop support for older versions.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism
Copy link
Member

Fixed in #1087. There is now a separate metadata per bind, which stores the bind key and tables. Reflection is done on each metadata, and does not need extra tracking in the table.

@davidism davidism closed this Sep 18, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Reflect not returning respective Bind
2 participants