Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flash fails in nonobvious way when secret isn't set #10

Closed
cgrinds opened this issue Apr 17, 2010 · 1 comment
Closed

Flash fails in nonobvious way when secret isn't set #10

cgrinds opened this issue Apr 17, 2010 · 1 comment

Comments

@cgrinds
Copy link
Contributor

cgrinds commented Apr 17, 2010

Here's what fails http://paste.pocoo.org/show/202792/

The Flash section of the docs should at least mention that app.secret is required but I'm not sure that's enough.

One idea would be to require secret_key to be explicitly set and fail to run if it isn't.
For folks that don't need sessions they could pass a message to that effect to run().
My guess is session/flash will be used by more apps than not.

@mitsuhiko
Copy link
Contributor

Session falls back to a dummy object now if secret_key is missing.

This makes it possible to still read-only access the empty session but
requires the secret key to be set for write access. The error message
raised explains that. This closed by 5310fc3.

erishforG added a commit to erishforG/flask that referenced this issue Mar 30, 2015
translation for last paragraph in Micro
erishforG added a commit to erishforG/flask that referenced this issue Jun 22, 2015
update for translationg htmlfaq.rst pallets#10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants