Moved open_session call from RequestContext.push to wsgi_app

[WeirdCarrotMonster]

Fixes #1528

New approach has only one drawback: in any custom tests that require sessions, you need to call ctx_open_session directly. I fixed existing tests in flask, but any user test may fail.

[keyan]

@WeirdCarrotMonster I'm concerned about breaking backwards compatibility. Is there anyway to avoid this? Did you update the docs to reflect your proposed change?

[WeirdCarrotMonster]

@keyan It's not as compatible as i'd like it to be. The problem is: current approach on managing RequestContext and sessions is wrong. I'm not sure if it can be fixed without breaking compatibility for some people, especially if they use test_request_context and session in their code.

I haven't updated the docs yet, since i hope there is better solution.

[vagamens]

would it be possible to reimplement those functions using the newer apis?

On 08/03/2015 03:09 AM, Eugene Protozanov wrote:

It's not as compatible as i'd like it to be. The problem is: current
approach on managing RequestContext and sessions is wrong. I'm not
sure if it can be fixed without breaking compatibility for some
people, especially if they use |test_request_context| and |session| in
their code.

I haven't updated the docs yet, since i hope there is better solution.

—
Reply to this email directly or view it on GitHub
#1538 (comment).

[ThiefMaster]

Also, please clean up the PR a bit. There shouldn't be merge commits in a PR at all (you always rebase feature branches to sync them with upstream) and the various test-related commits could be squashed into a single one.