Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for PEP451 import loaders and pytest 5.x #3278

Merged
merged 1 commit into from Jul 1, 2019
Merged

Fixes for PEP451 import loaders and pytest 5.x #3278

merged 1 commit into from Jul 1, 2019

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Jul 1, 2019 •
edited

  • pytest 5.x drops python2 compatibility and therefore only implements PEP 451
  • pytest 5.x made the repr of ExcInfo less confusing (fixed tests depending
    on the old format)

Resolves #3275
Resolves #3277

@asottile asottile mentioned this pull request Jul 1, 2019
Closed
@davidism davidism mentioned this pull request Jul 1, 2019
Closed
@asottile
Copy link
Contributor Author

asottile commented Jul 1, 2019

oof, let me figure out the pypy3 failure :S

@asottile
Copy link
Contributor Author

asottile commented Jul 1, 2019

hmmm weird, on pypy3 it's detecting site_egg as a namespace package and not giving it a __spec__ 🤔

@asottile
Copy link
Contributor Author

asottile commented Jul 1, 2019

ok I'm slightly wrong about the namespace package classification -- that appears to be a bug in pypy: https://bitbucket.org/pypy/pypy/issues/3034/egg-__spec__-is-none-if-queried-while

@asottile
Copy link
Contributor Author

asottile commented Jul 1, 2019

actually, let me try another approach that makes pypy less special

@asottile
Copy link
Contributor Author

asottile commented Jul 1, 2019

ok, I'm happy with this implementation now

@asottile @davidism
Fixes for PEP451 import loaders and pytest 5.x
a5ecdfa 
- pytest 5.x drops python2 compatibility and therefore only implements PEP 451
- pytest 5.x made the repr of `ExcInfo` less confusing (fixed tests depending
  on the old format)
@davidism
Copy link
Member

davidism commented Jul 1, 2019

Thanks! Fixed a naming issue, all envs should pass now.

@davidism davidism merged commit 043443d into pallets:1.0.x Jul 1, 2019
@asottile
Copy link
Contributor Author

asottile commented Jul 1, 2019

awesome thanks for the fixup! stepped out for a run and totally missed that 👍

@asottile asottile deleted the importlib_spec branch July 1, 2019 18:00
@byronz byronz mentioned this pull request Jul 2, 2019
Merged
@asottile asottile mentioned this pull request Sep 19, 2019
Open
@lbeaufort lbeaufort mentioned this pull request Oct 11, 2019
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asottile @davidism