some more work on py 3.3 port #736
Conversation
removed init_jinja_globals hack from app.py after consulting mitsuhiko (didn't work on py 3.3 "as is") removed with_statement future imports, not needed any more needs more work on 2.7 as well as on 3.3
|
Why did you remove |
|
because the port target is 2.6/2.7/3.3 and all these have the with statement (without using the future import). |
|
There's no need to break backward compatibility with 2.5. http://flask.pocoo.org/docs/installation/, third paragraph. |
|
@Gioi It's already decided not to support anything older than 2.6, also Werkzeug won't support 2.5 anymore. |
|
And there is a need / a reason to break it, see mitsuhiko's nice article there: http://lucumr.pocoo.org/2013/5/21/porting-to-python-3-redux/ |
|
Thank you, I simply didn't know that. So, let's add a notice to the docs ;-) |
|
So we're going to drop 2.5 compatibility without any notice on the website and current version docs. |
|
@Gioi I did link a commit with such changes to the docs. |
|
@Gioi We already did that with itsdangerous and jinja2. If this approach would cause problems people would already complain but so far no one has. On the other side people do quite regularly complain about lack of 3.x support and the amount of complaints on that front are continually increasing. The community has made their opinion clear and I don't see a reason to appeal to a group that may or may not exist. |
|
@untitaker I have noticed it, have you noticed that http://flask.pocoo.org/docs/installation/ (aka current version documentation) is not updated? |
|
Hmm, yeah, i actually have to agree with @Gioi, it could've been announced in the current docs. I doubt many users will be surprised by the drop of 2.5 though, since the majority is following Armin's Twitter account, and he did mention it there. |
still lots of bytes vs unicode stuff to do
also some strange test fails on 2.7, please have a look