Fixed json.jsonify

[devilicecream]

Modified jsonify to allow passing the same parameters of json.dumps (expecially to support custom encoders). Test suite updated to support the update.

[untitaker]

But that would break all existing code that currently uses jsonify!

[anas-aldrees]

Add it as a new function, mark the old function as depreciated.
On Jul 5, 2013 12:13 AM, "Markus Unterwaditzer" notifications@github.com
wrote:

But that would break all existing code that currently uses jsonify!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/790#issuecomment-20493689
.

[devilicecream]

You're right, sorry!
My original idea was to make a decorator that works as jsonify, but
allowing the behaviour I used in my code... Do you think it could be a good
improvement?

2013/7/4 Markus Unterwaditzer notifications@github.com

But that would break all existing code that currently uses jsonify!

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/790#issuecomment-20493689
.

[untitaker]

devilicecream, i honestly don't know. I never had the need for custom json encoders. I always convert my data to native types before passing to jsonify, mostly because the explicitness gives me some sense of security. I can see why people would want to use it though.

[untitaker]

Maybe split the current jsonify into one func that takes stdlib-like args, and a second one that wraps the first one?

[devilicecream]

I like this solution. I'm doing it :) thank u!

2013/7/4 Markus Unterwaditzer notifications@github.com

Maybe split the current jsonify into one func that takes stdlib-like args,
and a second one that wraps the first one?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/790#issuecomment-20493973
.

[devilicecream]

Done as a wrapper, but i'm not really sure about this implementation. Maybe it will be better if i made both functions indipendent from the other. Waiting for suggests

[DasIch]

You can already use a custom encoder by subclassing Flask and overriding the json_encoder class attribute see http://flask.pocoo.org/docs/api/#flask.Flask.json_encoder