New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Windows UNC paths in loaders #1913

Open

KapJI wants to merge 1 commit into pallets:main from KapJI:unc-paths

KapJI commented Nov 30, 2023

Replace os.path.normpath with str(pathlib.Path()) which correctly fixes path separators when UNC path is provided.

Tested that this code doesn't escape search dir, e.g.:

>>> str(pathlib.Path(posixpath.join("C:\\abc", "e:d\\ef")))
'C:\\abc\\e:d\\ef'
>>> str(pathlib.Path(posixpath.join("\\\\?\\C:\\abc", "e:d\\ef")))
'\\\\?\\C:\\abc\\e:d\\ef'

fixes Faulty handling of UNC paths #1675

Checklist:

Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
Add or update relevant docs, in the docs folder and in code.
Add an entry in CHANGES.rst summarizing the change and linking to the issue.
Add .. versionchanged:: entries in any relevant code docs.
Run pre-commit hooks and fix any issues.
Run pytest and tox, no tests failed.


          Support Windows UNC paths in loaders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment