Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor PackageLoader to use importlib.resources #1978

Open
davidism opened this issue May 13, 2024 · 1 comment · May be fixed by #1985
Open

refactor PackageLoader to use importlib.resources #1978

davidism opened this issue May 13, 2024 · 1 comment · May be fixed by #1985

Comments

@davidism
Copy link
Member

davidism commented May 13, 2024 •
edited

I had to ignore a failing test when adding 3.13 to the test matrix #1977, as the zip importer no longer exposes a private _files list for PackageLoader.list_templates to use. Presumably I didn't use importlib.resources before because I had to support older Python versions? Either way, should be able to now. Consider the importlib_resources backport for 3.7 and 3.8 so we can use the files API in all versions.
@danwuSBU
Copy link

looking at this at PyCon sprint

@danwuSBU danwuSBU linked a pull request May 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor PackageLoader to use importlib_resources danwuSBU/jinja
2 participants
@davidism @danwuSBU