Do not attempt to compile extensions for pypy and jython. This fixes #4

pallets · Jul 20, 2011 · 515ec27 · mcdonc · Jul 20, 2011 · mitsuhiko
1 parent 178f605
commit 515ec27
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 17 deletions.
diff --git a/CHANGES b/CHANGES
@@ -1,6 +1,12 @@
 MarkupSafe Changelog
 ====================
 
+Version 0.13
+------------
+
+- Do not attempt to compile extension for PyPy or Jython.
+- Work around some 64bit Windows issues.
+
 Version 0.12
 ------------
 

diff --git a/markupsafe/_speedups.c b/markupsafe/_speedups.c
@@ -64,9 +64,9 @@ escape_unicode(PyUnicodeObject *in)
 
 	/* First we need to figure out how long the escaped string will be */
 	while (*(inp) || inp < inp_end) {
-		if (*inp < ESCAPED_CHARS_TABLE_SIZE && escaped_chars_delta_len[*inp]) {
+		if (*inp < ESCAPED_CHARS_TABLE_SIZE) {
 			delta += escaped_chars_delta_len[*inp];
-			++erepl;
+			erepl += !!escaped_chars_delta_len[*inp];
 		}
 		++inp;
 	}

diff --git a/setup.py b/setup.py
@@ -9,6 +9,9 @@
 # fail safe compilation shamelessly stolen from the simplejson
 # setup.py file.  Original author: Bob Ippolito
 
+is_jython = 'java' in sys.platform
+is_pypy = hasattr(sys, 'pypy_version_info')
+
 
 speedups = Feature(
     'optional C speed-enhancement module',
@@ -92,21 +95,29 @@ def run_setup(with_binary):
     )
 
 
-try:
+def try_building_extension():
-    run_setup(True)
+    try:
-except BuildFailed:
+        run_setup(True)
-    LINE = '=' * 74
+    except BuildFailed:
-    BUILD_EXT_WARNING = 'WARNING: The C extension could not be compiled, speedups are not enabled.'
+        LINE = '=' * 74
+        BUILD_EXT_WARNING = 'WARNING: The C extension could not be ' \
+                            'compiled, speedups are not enabled.'
+
+        echo(LINE)
+        echo(BUILD_EXT_WARNING)
+        echo('Failure information, if any, is above.')
+        echo('Retrying the build without the C extension now.')
+        echo()
+
+        run_setup(False)
 
-    echo(LINE)
+        echo(LINE)
-    echo(BUILD_EXT_WARNING)
+        echo(BUILD_EXT_WARNING)
-    echo('Failure information, if any, is above.')
+        echo('Plain-Python installation succeeded.')
-    echo('Retrying the build without the C extension now.')
+        echo(LINE)
-    echo()
 
-    run_setup(False)
 
-    echo(LINE)
+if not (is_pypy or is_jython):
-    echo(BUILD_EXT_WARNING)
+    try_building_extension()
-    echo('Plain-Python installation succeeded.')
+else:
-    echo(LINE)
+    run_setpu(False)