Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is not getting correct url root #39

Closed
davidism opened this issue May 13, 2021 · 1 comment · Fixed by #43
Closed

Search is not getting correct url root #39

davidism opened this issue May 13, 2021 · 1 comment · Fixed by #43
Assignees

Comments

@davidism
Copy link
Member

Search on the newly rendered docs is causing a 404/infinite redirect error. This happens on both RTD and locally, it doesn't appear to be an issue with RTD. It seems that {{ url_root }} is empty for some reason, at this line:

<script>DOCUMENTATION_OPTIONS.URL_ROOT = '{{ url_root }}';</script>

Screenshot from 2021-05-13 08-54-10

@davidism
Copy link
Member Author

davidism commented May 21, 2021

We can revert #3, as Sphinx is handling dirhtml search correctly now and is no longer providing the variable we used to apply the workaround, so we're breaking search now.

Not sure when Sphinx fixed search, but they removed the variable in sphinx-doc/sphinx#8732.

@davidism davidism self-assigned this May 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants