Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect canonical links on project website #47

Closed
mosheduminer opened this issue May 24, 2021 · 2 comments · Fixed by #53
Closed

Incorrect canonical links on project website #47

mosheduminer opened this issue May 24, 2021 · 2 comments · Fixed by #53

Comments

@mosheduminer
Copy link

On the flask website, every page has a tag with the canonical link for the page. However, the canonical link for a page (for example, https://flask.palletsprojects.com/en/2.0.x/foreword/) includes .html at the end (for example, https://flask.palletsprojects.com/en/2.0.x/foreword.html). The problem is that following the canonical link (with the .html) results in a 404. This seems to be true for all pages except for those ending /index.html (such as the home page, whose canonical link is https://flask.palletsprojects.com/en/2.0.x/index.html). I noticed this behavior when a friend shared a link to the website, and the browser used the canonical link, resulting in a 404.

This seems to be the best venue to report this, if not, please point me in the right direction.

@davidism davidism transferred this issue from pallets/flask May 24, 2021
@davidism
Copy link
Member

This is a bug with Sphinx >= 1.8 sphinx-doc/sphinx#9730

@davidism
Copy link
Member

Although I think I can detect the issue and work around it in this theme.

@davidism davidism reopened this Nov 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants