Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dark mode #48

Closed
jwogrady opened this issue May 26, 2021 · 6 comments
Closed

dark mode #48

jwogrady opened this issue May 26, 2021 · 6 comments

Comments

@jwogrady
Copy link

jwogrady commented May 26, 2021

I am requesting a dark mode version of the website and documentation. It's not about my personal style preference. It's a usability issue since I am presently dealing with cataracts.

A dark theme can be easier to read because it reduces light and improves contrast. An alternate solution would be having the ability to change the style.

I want to thank you for Flask. It's incredible.

@ThiefMaster
Copy link
Member

I'm sure a contribution to https://github.com/pallets/pallets-sphinx-themes that adds a dark mode would be welcome :)

@davidism
Copy link
Member

I don't personally use dark mode much, I find it harder to read paragraphs in (code is a different story, but the docs and website are mostly prose). If someone wants to contribute a dark theme, that's fine, but it needs to integrate with the system preference as well as be toggleable (with the preference stored in local storage).

local storage user choice > system preference > light mode default

@davidism davidism transferred this issue from pallets/flask May 26, 2021
@davidism davidism changed the title Dark Mode Website and Documentation dark mode May 26, 2021
@yuxiaoy1
Copy link
Contributor

yuxiaoy1 commented Jul 6, 2021

Hi, I'm working on this feature.
Do we need configuration to enable/disable the dark mode (show/hide the switch)?

@ThiefMaster
Copy link
Member

I think giving users the option to toggle it (persistently - save it e.g. in localStorage) is enough.

@yuxiaoy1
Copy link
Contributor

yuxiaoy1 commented Jul 6, 2021

Got it.
One more question, the themes/babel folder is unused, right? I checked the conf.py of babel, and it didn't involve the pallets-sphinx-thmes.

@davidism
Copy link
Member

davidism commented Jun 8, 2023

We're planning to switch to Furo as a base theme, which will provide a dark mode.

@davidism davidism closed this as completed Jun 8, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants