Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script gets exited when there is no response from fetch slot API #33

Closed
agabhane opened this issue May 5, 2021 · 10 comments
Closed

Script gets exited when there is no response from fetch slot API #33

agabhane opened this issue May 5, 2021 · 10 comments
Assignees
Labels
not-an-issue This is not an issue.

Comments

@agabhane
Copy link

agabhane commented May 5, 2021

Due to heavy load sometimes the API used for fetching the slots availability returns no response.
As a result the exe program gets exited with beep saying NoneType cannot be iterated.

User have to start whole script again.

@vatgarg
Copy link

vatgarg commented May 5, 2021

Its already resolved in this fork , main branch

https://github.com/vatgarg/covid-vaccine-booking

@pallupz
Copy link
Owner

pallupz commented May 5, 2021

I will try to address it here as well

@vatgarg
Copy link

vatgarg commented May 5, 2021

@pallupz I opened a PR, if you could merge.

@vatgarg
Copy link

vatgarg commented May 5, 2021

Aw okay. Yea please maintain the quality, but dont block the conversation. :) Well, i didnt realise, i was just extracting bigger methods of your code to smaller ones :)

@vatgarg
Copy link

vatgarg commented May 5, 2021

@pallupz But Anyways, you were the author of the code, and it worked. So, no regrets. Thanks anyways..

@pallupz
Copy link
Owner

pallupz commented May 5, 2021

@agabhane : Did you happen to take a screenshot of the issue? This shouldn't have happened. Even better, if you're able to reproduce it, please do let me know which state/district you had used.

@pallupz pallupz added the good first issue Good for newcomers label May 5, 2021
@pallupz pallupz self-assigned this May 5, 2021
@agabhane
Copy link
Author

agabhane commented May 5, 2021

Hi @pallupz ,

I did not take the screenshot. Anyways the issue got resolved after takig update from https://github.com/vatgarg/covid-vaccine-booking.
FYI. I was checking the slots for Maharashtra -> Pune

@pallupz pallupz closed this as completed May 5, 2021
@pallupz pallupz added not-an-issue This is not an issue. and removed good first issue Good for newcomers labels May 5, 2021
@agabhane
Copy link
Author

agabhane commented May 5, 2021

Hi @pallupz
Booked the slots two times. Worked really well.

Kudos.

@pallupz
Copy link
Owner

pallupz commented May 5, 2021

Thank you for coming back to mention this. That really mean a lot! 👍

@pallupz
Copy link
Owner

pallupz commented May 5, 2021

Please feel free to spread the word a bit, if you don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-an-issue This is not an issue.
Projects
None yet
Development

No branches or pull requests

3 participants