Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Credentials to use HTTPClient instead of requests #93

Closed
sserrata opened this issue Aug 13, 2018 · 0 comments
Closed

Refactor Credentials to use HTTPClient instead of requests #93

sserrata opened this issue Aug 13, 2018 · 0 comments
Assignees
@sserrata
Labels
enhancement New feature or request

Comments

@sserrata
Copy link
Member

  • Palo Alto Networks Cloud Python SDK version: 1.3.0
  • Python version: 2.7, 3.5+
  • Operating System: any

Description

Currently, the Credentials class implements its own, separate requests.Session for making HTTP requests. Although this is functionally ok, it's counter to the goal of maintaining HTTP persistence and other performance tuning options, in a unified manner.

Proposed solution

Refactor Credentials class and applicable methods to use HTTPClient in place of requests.Session. This solution should also support passing a shared HTTPClient object as a session parameter in addition to the override feature currently supported by the other service modules.
@sserrata sserrata added the enhancement New feature or request label Aug 13, 2018
@sserrata sserrata self-assigned this Aug 13, 2018
@sserrata sserrata mentioned this issue Sep 6, 2018
Merged
@sserrata sserrata closed this as completed Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sserrata sserrata

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sserrata