AWS Organizations integration fails after scanning the first member account

[acdha]

Describe the bug

When run using org mode, the first member account will be scanned. All of the other accounts will fail.

Expected behavior

It should scan all of the member accounts

Current behavior

Warning: Failed to assume role into Member Account …, skipping ...

If you remove the 2>/dev/null which discards the error output from the aws sts assume-role command you'll see this additional detail:

Unable to locate credentials. You can configure credentials by running "aws configure".

Possible solution

Reviewing the code from #2, I believe the problem is related to the way assume_role() overwrites its current credentials with the assumed role credentials, which allows that account to be scanned but then causes all subsequent accounts to fail since you'd need to call sts:AssumeRole using the original credentials.

pcs-sizing-scripts/aws/resource-count-aws.sh

Lines 266 to 279 in 73fbe9a

	SESSION_JSON=$(aws_sts_assume_role "${ACCOUNT_ASSUME_ROLE_ARN}")
	if [ $? -ne 0 ] || [ -z "${SESSION_JSON}" ]; then
	ASSUME_ROLE_ERROR="true"
	echo " Warning: Failed to assume role into Member Account ${ACCOUNT_NAME} (${ACCOUNT_ID}), skipping ..."
	else
	# Export environment variables used to connect to this member account.
	AWS_ACCESS_KEY_ID=$(echo "${SESSION_JSON}" | jq .Credentials.AccessKeyId 2>/dev/null | sed -e 's/^"//' -e 's/"$//')
	AWS_SECRET_ACCESS_KEY=$(echo "${SESSION_JSON}" | jq .Credentials.SecretAccessKey 2>/dev/null | sed -e 's/^"//' -e 's/"$//')
	AWS_SESSION_TOKEN=$(echo "${SESSION_JSON}" | jq .Credentials.SessionToken 2>/dev/null | sed -e 's/^"//' -e 's/"$//')
	export AWS_ACCESS_KEY_ID
	export AWS_SECRET_ACCESS_KEY
	export AWS_SESSION_TOKEN
	fi
	fi

Steps to reproduce

1. Run resource-count-aws.sh org with credentials in the Organization master account for an IAM user which has permission to assume the OrganizationAccountAccessRole in each member account.

[welcome-to-palo-alto-networks]

🎉 Thanks for opening your first issue here! Welcome to the community!

[tkishel]

Could you test the above PR?