Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move events from inner classes to their own package #5

Closed
palra opened this issue Jun 9, 2015 · 0 comments
Closed

Move events from inner classes to their own package #5

palra opened this issue Jun 9, 2015 · 0 comments

Comments

@palra
Copy link
Owner

palra commented Jun 9, 2015

We should stop put events in inner classes, for more readability. Also, it is more easier for a future developer to find the events classes in a dedicated package than searching on a class. Inner classes should be used if we really need to access inner attributes of the parent class, but that's not the case, as we pass them in argument.

My proposal is to create a package event in our working package (for example : fr.univdevs.mmorpg.engine.event) and put subpackages for each topic (fr.univdevs.mmorpg.engine.event.action)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants