make sure _compare database gets cleaned up if errors occur

paltman-archive · Oct 4, 2012 · f4ee5bf · f4ee5bf
1 parent d6383b5
commit f4ee5bf
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/nashvegas/management/commands/comparedb.py b/nashvegas/management/commands/comparedb.py
@@ -74,14 +74,16 @@ def handle(self, *args, **options):
         self.setup_database()
         connections[self.db].close()
         connections[self.db].settings_dict["NAME"] = self.compare_name
-        call_command("syncdb", interactive=False, verbosity=0)
-        new_sql = Popen(
-            command.format(dbname=self.compare_name).split(),
-            stdout=PIPE
-        ).stdout.readlines()
-        connections[self.db].close()
-        connections[self.db].settings_dict["NAME"] = self.current_name
-        self.teardown_database()
+        try:
+            call_command("syncdb", interactive=False, verbosity=0)
+            new_sql = Popen(
+                command.format(dbname=self.compare_name).split(),
+                stdout=PIPE
+            ).stdout.readlines()
+        finally:
+            connections[self.db].close()
+            connections[self.db].settings_dict["NAME"] = self.current_name
+            self.teardown_database()
 
         print "Outputing diff between the two..."
         print "".join(difflib.unified_diff(normalize_sql(current_sql),