Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duplicate UUIDs in playbooks #7

Closed
jmgnc opened this issue Feb 7, 2019 · 3 comments
Closed

duplicate UUIDs in playbooks #7

jmgnc opened this issue Feb 7, 2019 · 3 comments

Comments

@jmgnc
Copy link

jmgnc commented Feb 7, 2019

When reviewing the data, I noticed that some objects have the same uuid, but different type. I believe that most people are under the assumption that the UUID part of the identifier is unique among all objects, and that the type prefix is NOT required to make the identifier unique. As it is, if someone makes this assumption, they will not be able to use your data.

For example, in https://github.com/pan-unit42/playbook_viewer/blob/master/playbook_json/patchwork.json , the UUID, 4832076b-7a4c-4952-8853-6446de513176, is used for a relationship, a report and a campaign.

$grep 4832076b-7a4c-4952-8853-6446de513176 patchwork.json | grep id 
      "id": "relationship--4832076b-7a4c-4952-8853-6446de513176",
      "id": "report--4832076b-7a4c-4952-8853-6446de513176",
      "id": "campaign--4832076b-7a4c-4952-8853-6446de513176",

This happens in other playbooks as well.

@borgendorf
Copy link

Good eye! Also note that the STIX 2.1 Specification calls this out explicitly in section 2.9 Identifier:

The UUID part of the identifier MUST be unique across all objects produced by a given producer regardless of the type identified by the object-type prefix. Meaning, a producer MUST NOT reuse the UUID portion of the identifier for objects of different types.

@jmgnc
Copy link
Author

jmgnc commented Mar 31, 2020

Yes, this clarification was added explicitly because of cases like these.

@eiyuki
Copy link
Contributor

eiyuki commented Sep 30, 2021

This issue has been resolved in 7adecdc as a prerequisite for updating the Playbooks to STIX 2.1.

@eiyuki eiyuki closed this as completed Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants