Skip to content
This repository has been archived by the owner on Jul 31, 2021. It is now read-only.

Swapping through low-liquidity pairs #95

Open
aterehov opened this issue Dec 20, 2020 · 3 comments
Open

Swapping through low-liquidity pairs #95

aterehov opened this issue Dec 20, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@aterehov
Copy link

aterehov commented Dec 20, 2020

Bug Description
Website offers to swap some tokens through low-liquidity pairs while there are high-liquidity pairs for the same tokens. Examples:
For BNB to CAKE website offers to use BNB > BUSD > CAKE, while the better route is BNB > CAKE (directly), because there is an $11M pair for that.
USDT to NYA swap: website offers USDT > WBNB > NYA, while the better route is USDT > WBNB > CAKE > NYA (more liquidity there)

Steps to Reproduce

  1. Go to exchange.pancakeswap.finance
  2. Set a swapping route: from USDT to NYA (it shows out the bug more clearly and appears more often)
  3. Enter "20" in the top field (USDT)
  4. You will see the wrong route USDT > WBNB > NYA
    ...

Expected Behavior
A correct route for USDT > NYA example is USDT > WBNB > CAKE > NYA (or any other through CAKE). The same is for other routes: it should rather choose high-liquidity pairs.

Additional Context
Some screenshots showing examples above with wrong routes
Снимок экрана от 2020-12-21 02-46-35
Снимок экрана от 2020-12-21 02-11-17

@aterehov aterehov added the bug Something isn't working label Dec 20, 2020
@geckah
Copy link

geckah commented Feb 14, 2021

Having the same issue with eth - compound. It goes through bnb resulting in high price impact

@RabbitDoge RabbitDoge self-assigned this Feb 24, 2021
@RabbitDoge
Copy link
Contributor

The eth/comp bug is fixed. I'll check for the cake pair.

@masha256
Copy link

masha256 commented Apr 1, 2021

I'm seeing the same for BUSD to ETH. It wants to route BUSD -> WBNB -> ETH when there is a BUSD/ETH LP with $1.9M USD worth of liquidity in it. This results in paying twice the fee on a swap since it routes through two pools instead of one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants