Chore/update eslint config in package json #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Chef-Cheems
commented
Jul 9, 2021
Chef-Cheems
commented
- update eslint-config-pancake for repo
- fix token-lists package linting
Chef-Cheems
requested review from
Chef-Chungus,
ChefKai,
hachiojidev and
RabbitDoge
as code owners
Chef-Cheems
commented
Jul 9, 2021
| const main = async () => { | ||
| const tokens = await getTokens(); | ||
| const main = async (): Promise<void> => { | ||
| try { |
There was a problem hiding this comment.
Big diff here is just wrapping it all in try-catch (done to get rid of consistent-return error within getTokens())
Chef-Cheems
force-pushed
the
chore/update-eslint-config-in-package-json
branch
from
582e18b
to
109532f
Compare
hachiojidev
approved these changes
Jul 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.