feat: Add minWidth and headerBackground props to Modal #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hachiojidev
reviewed
Mar 23, 2021
| @@ -48,9 +51,11 @@ const Modal: React.FC<Props> = ({ | |||
| children, | |||
| hideCloseButton = false, | |||
| bodyPadding = "24px", | |||
| headerBackground = "transparent", | |||
| minWidth = "360px", | |||
There was a problem hiding this comment.
Why put the minWidth on the title and not the parent?
There was a problem hiding this comment.
minWidth is added to the parent. It just looks like that it is added to the Title in the git. :)
hachiojidev
approved these changes
Mar 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Before opening a pull request, please read the contributing guidelines first
[ ] If your PR is work in progress, open it as
draft[ ] Before requesting a review, all the checks need to pass
[ ] Explain what your PR does