Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make yarn test fire on pull_request and fix snapshot fail on master #59

Merged
merged 7 commits into from
Apr 8, 2021

Conversation

ChefHutch
Copy link
Contributor

@ChefHutch ChefHutch commented Apr 8, 2021

Problem

I noticed that a test was failing on master. It turns out that the push action only seems to run before a branch has been PRed - i.e. - https://github.com/ChefHutch/pancake-toolkit/runs/2295909352 (the first push to this branch before I created the PR).

Once PRed, the action doesn't seem to run. Notice CI passes (with a failing test) for every commit in this PR before I add the on: [... pull_request] value in e4dd4e7 (at which point yarn test fires, and CI fails. Woot!).

Screenshot 2021-04-08 at 11 44 59

Code changes

  • Make test action run on pull_request
  • Tidy syntax to match other actions
  • Update failing snapshot

@ChefHutch ChefHutch self-assigned this Apr 8, 2021
@ChefHutch ChefHutch changed the title test(test.yml): Experiment change workflow job name to see if triggers Make yarn test fire on pull_request and fix snapshot fail on master Apr 8, 2021
@ChefHutch ChefHutch marked this pull request as ready for review April 8, 2021 10:54
Copy link
Contributor

@Chef-Cheems Chef-Cheems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
I wonder if push even necessary. In case you push the branch but decide not to open a PR and abandon the branch - actions ran for nothing.

Seems like other pipelines don't have push at all and doing just fine.

@hachiojidev hachiojidev merged commit 7a0e090 into pancakeswap:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants