Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

memory callbacks missing on MIPS #1179

Open
lacraig2 opened this issue Feb 23, 2022 · 0 comments · May be fixed by #1163
Open

memory callbacks missing on MIPS #1179

lacraig2 opened this issue Feb 23, 2022 · 0 comments · May be fixed by #1163

Comments

@lacraig2
Copy link
Member

MIPS is missing memory callbacks on more complicated instructions that involve helpers.

In particular, it is missing swr, swl, lwl, and lwr (and 64-bit equivalents).

https://github.com/panda-re/panda/blob/dev/target/mips/op_helper.c#L318-L358

Related: #1163, #1119
@lacraig2 lacraig2 linked a pull request Feb 23, 2022 that will close this issue
Fix memory callback coverage #1163
Open
@lacraig2 lacraig2 linked a pull request Feb 24, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix memory callback coverage panda-re/panda
1 participant
@lacraig2