Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyPanda: check for TTY before using color #1180

Closed
grant-h opened this issue Feb 25, 2022 · 1 comment · Fixed by #1181
Closed

PyPanda: check for TTY before using color #1180

grant-h opened this issue Feb 25, 2022 · 1 comment · Fixed by #1181

Comments

@grant-h
Copy link

grant-h commented Feb 25, 2022

Color is used without an isatty check or controlling flag. When piping logs to a file this will result in escape sequences being saved.

panda/panda/python/core/pandare/utils.py

Line 20 in 047266e

print(Fore.GREEN + '[PYPANDA] ' + Fore.RESET + Style.BRIGHT + msg +Style.RESET_ALL)

@lacraig2 lacraig2 mentioned this issue Feb 25, 2022
Merged
@lacraig2
Copy link
Member

Nice catch. Fairly easy fix. PR linked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add checks for stdout in tty in utils panda-re/panda
2 participants
@grant-h @lacraig2