Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerhub images not updating #1407

Closed
AndrewFasano opened this issue Dec 28, 2023 · 4 comments
Closed

Dockerhub images not updating #1407

AndrewFasano opened this issue Dec 28, 2023 · 4 comments
Labels
infrastructure Issues related to infrastructure (CI, containers, qcows) instead of core PANDA code/

Comments

@AndrewFasano
Copy link
Member

The last update to our dockerhub images happened 14 days ago, but we've merged some PRs since and our CI jobs have successfully run on them.

For example in https://github.com/panda-re/panda/actions/runs/7344249533/job/19995838781 we build the panda and pandadev containers, but it seems like they're no longer pushed to dockerhub

@AndrewFasano AndrewFasano added the infrastructure Issues related to infrastructure (CI, containers, qcows) instead of core PANDA code/ label Dec 28, 2023
@AndrewFasano AndrewFasano changed the title [CI] Dockerhub images not updating Dockerhub images not updating Dec 28, 2023
@cctv130
Copy link

cctv130 commented Dec 29, 2023

I suggest that we should be able to please the core functions of into the https://github.com/tklengyel/drakvuf (for example the replay, records, etc.), the activity of panda is very low, completely lost confidence to me.

@coolkingcole
Copy link
Collaborator

@cctv130 If you'd like to change something about the core functionality of panda, open an issue and you can ideally make the changes you would like into a pull request. This issue is about a breaking change in relation to recent CI/CD changes.

@coolkingcole
Copy link
Collaborator

@AndrewFasano I think this commit fixes it. The latest is pushed now.

Added to docker actions:

with:
   push: true

Also each container is tagged with its hash and a shorter tag now.

@AndrewFasano
Copy link
Member Author

Amazing, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Issues related to infrastructure (CI, containers, qcows) instead of core PANDA code/
Projects
None yet
Development

No branches or pull requests

3 participants