Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLEAN: cleanup up platform / python version checks #10151

Closed
jreback opened this issue May 15, 2015 · 1 comment
Closed

CLEAN: cleanup up platform / python version checks #10151

jreback opened this issue May 15, 2015 · 1 comment
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented May 15, 2015

we have in various locations

os.name, platform.system(), sys.platform

for detecting platform. Recently add are these functions
in pandas/compat/__init__.py as is_platform_* which are reasonable to standardize on

however, need to find & fix all the other references to make this nice and clean
this includes code and tests

Ideally also add: skip_if_windows functions in pandas/util/testing.py (and replace the use of the direct comparisons) would be gr8.

futhermore any references to to python 3 checks should use PY3 (in pandas/compat):

./pandas/tseries/tests/test_timeseries.py:
   50 :     if sys.version_info > (3,) and sys.platform == 'win32':
   54 :     if sys.version_info < (3,) or sys.platform != 'win32':

I think we could use an update on the wiki on the same

@jreback
Copy link
Contributor Author

jreback commented Jul 11, 2015

closed by #10542

@jreback jreback closed this as completed Jul 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant