New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixing CustomBusinessDay and BusinessHours Classes #11514

Closed
r-pluss opened this Issue Nov 3, 2015 · 1 comment

Comments

Projects
None yet
3 participants
@r-pluss

r-pluss commented Nov 3, 2015

Is it currently possible to combine the CustomBusinessDay and BusinessHour classes in any way?

My use-case is that I want to be able to create a SubClass of BusinessHour that would skip over all time occurring in the 'holidays' or outside the 'weekmask' defined within a CustomBusinessDay instance. This would be incredibly useful for me, and, I suspect, many others.

I have currently tried subclassing BusinessHour and replacing the next_bday attribute with in an instance of a CustomBusinessDate. Unfortunately, it does not rollforward past days defined as holidays, and seems to function the same as a typical BusinessDay object.

If such functionality is not currently available, please consider this a feature request.

@jreback jreback added the Frequency label Nov 5, 2015

@sinhrks

This comment has been minimized.

Show comment
Hide comment
@sinhrks

sinhrks Nov 7, 2015

Member

Currently no.

I assume it should work by replacing BusinessDay to CustomBusinessDay used in BusinessHour. Pull request is appreciated!

Member

sinhrks commented Nov 7, 2015

Currently no.

I assume it should work by replacing BusinessDay to CustomBusinessDay used in BusinessHour. Pull request is appreciated!

@sinhrks sinhrks referenced this issue Apr 10, 2016

Closed

ENH: Support CustomBusinessHour #12847

4 of 4 tasks complete

@jreback jreback added this to the 0.18.1 milestone Apr 10, 2016

@jreback jreback added the Enhancement label Apr 10, 2016

@jreback jreback closed this in a1f5ef3 Apr 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment