-
-
Notifications
You must be signed in to change notification settings - Fork 17.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AbstractHolidayCalendar: suggestion to update documentation with correct usage #11533
Comments
You are right, your last example does not make any sense. It should skip 11/11 (just like the documentation example skips 7/4). Seems like something is not working as expected. As far as .holidays(startDate, endDate) I think we could add an example to the docs but this should probably go into the API documentation. The CDay import is suppressed by the docs -- from pandas.tseries.offsets import *. I don't see any harm in making this explicit. |
I do not see the same behavior as you not skipping 11/11 on pandas 0.17.0. Can you try and see if you see the same thing under 0.17.0?
|
Skipping 11/11 was not the point I was making. I think it probably should skip that day (Veterans Day). I was saying I expected it to give me back only the dates from the calendar, and instead it gave me back what looks like every day except the dates from the calendar. |
CDay is custom business day so it supposed to give business days skipping holidays/weekends. "The CDay or CustomBusinessDay class provides a parametric BusinessDay class which can be used to create customized business day calendars which account for local holidays and local weekend conventions." |
that's good. The docs need some better descriptions of when and how to actually use a calendar object. It's especially bad to introduce things like CDay that live elsewhere in the code without first defining them and/or linking to them. |
The text was updated successfully, but these errors were encountered: