BUG: Fix bug for kendall corr when in DF num and bool #11560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if i > j: | ||
| continue | ||
| elif i == j: | ||
| correl[i, i] = 1. |
There was a problem hiding this comment.
this is not correct if all of the values are NaN, then the result is Nan, so you can check that case or let this fall thru. Pls test for this (if its not done already)
jreback
added
the
Numeric Operations
roman-khomenko
force-pushed
the
roman-khomenko/fix-kendall-for-num-and-bool
branch
from
2091994
to
171ec36
Compare
|
@jreback Jeff, |
roman-khomenko
force-pushed
the
roman-khomenko/fix-kendall-for-num-and-bool
branch
from
171ec36
to
b04da65
Compare
| # so it need to be properly handled | ||
| df = DataFrame({"a": [True, False], "b": [1, 0]}) | ||
|
|
||
| expected = np.ones((2, 2), dtype=np.float64) |
There was a problem hiding this comment.
construct an actual DataFrame here and use assert_frame_equal for comparison
|
couple of comments. pls add a whatsnew (put in bug fixes), use this PR number as the issue number. squash, then ping when green. |
roman-khomenko
force-pushed
the
roman-khomenko/fix-kendall-for-num-and-bool
branch
2 times, most recently
from
babfe01
to
fe30837
Compare
roman-khomenko
force-pushed
the
roman-khomenko/fix-kendall-for-num-and-bool
branch
from
fe30837
to
f6b11fe
Compare
|
@jreback Done |
jreback
added a commit
that referenced
this pull request
Nov 13, 2015
…all-for-num-and-bool BUG: Fix bug for kendall corr when in DF num and bool
|
thanks! |
roman-khomenko
deleted the
roman-khomenko/fix-kendall-for-num-and-bool
branch
|
@jreback Thank you for pandas! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
so
np.isfinite(mat)will raise Exception.I've fixed this by using
com._ensure_float64like for other correlation.