NaT.isoformat() returns 'NaT'. #12300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Datetime
llllllllll
force-pushed
the
nat-isoformat
branch
from
76a2180 to
5134cb4
Compare
|
I am not sure if this is actually a good change. NaT is not defined by iso so idk if this is misleading. I just wanted to raise the issue. |
|
this would change the way JSON serializes I think. IIRC its the only thing that uses |
|
@llllllllll this looks fine. pls rebase and well put in. |
llllllllll
force-pushed
the
nat-isoformat
branch
2 times, most recently
from
a69e633 to
eb34f07
Compare
NaT.isoformat() returning 'NaT' allows users to use Timestamp to rehydrate any _Timestamp object from its isoformat. This means that it is safe to use _Timestamp.isoformat() as a serialization format for timestamps where NaT is a valid value.
|
build is passing, thanks! |
|
thanks @llllllllll |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NaT.isoformat() returning 'NaT' allows users to use Timestamp to
rehydrate any _Timestamp object from its isoformat. This means that it
is safe to use _Timestamp.isoformat() as a serialization format for
timestamps where NaT is a valid value.