Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: date_range closed parameter not honoured in pandas 0.18.0 #12684

Closed
PH82 opened this issue Mar 21, 2016 · 6 comments · Fixed by #13510
Closed

Regression: date_range closed parameter not honoured in pandas 0.18.0 #12684

PH82 opened this issue Mar 21, 2016 · 6 comments · Fixed by #13510
Labels
Regression Functionality that used to work in a prior pandas version Timeseries
Milestone

Comments

@PH82
Copy link

PH82 commented Mar 21, 2016

The behaviour of the method date_range appears to have changed between version 17 and 19. the below example changes the starting bound of the index returned?

print pd.date_range(start=datetime.datetime(2016,3,18,0,0), end=datetime.datetime(2016,3,22,0,0), freq='D', tz='UTC', closed='right')

pandas 0.17.0 Output
DatetimeIndex(['2016-03-19', '2016-03-20', '2016-03-21', '2016-03-22'], dtype='datetime64[ns, UTC]', freq='D')

pandas 0.18.0 Output
DatetimeIndex(['2016-03-18', '2016-03-19', '2016-03-20', '2016-03-21', '2016-03-22'],
dtype='datetime64[ns, UTC]', freq='D')

python: 2.7.11.final.0

@jreback
Copy link
Contributor

jreback commented Mar 21, 2016

this was originally this issue: #11804
and fixed here: #11806 and #12410

@jreback
Copy link
Contributor

jreback commented Mar 21, 2016

yeah this coerces to the basic data (i8) right before the closed detection which is incorrect.

pull-requests welcome!

@jreback jreback added Timeseries Regression Functionality that used to work in a prior pandas version Difficulty Novice labels Mar 21, 2016
@jreback jreback added this to the 0.18.1 milestone Mar 21, 2016
@jreback
Copy link
Contributor

jreback commented Mar 21, 2016

cc @hcontrast
cc @thrasibule

@jreback
Copy link
Contributor

jreback commented Mar 21, 2016

right about here

@PH82
Copy link
Author

PH82 commented Mar 21, 2016

Okay thanks, I'll keep an eye out for the fix.

@jreback
Copy link
Contributor

jreback commented Mar 21, 2016

@PH82 if you'd like to submit a patch would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Regression Functionality that used to work in a prior pandas version Timeseries
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants