Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: subclassed .align returns normal DataFrame #13037

Closed
wants to merge 1 commit into from

Conversation

sinhrks
Copy link
Member

@sinhrks sinhrks commented Apr 30, 2016

Also fixed a bug which Series.align(DataFrame) raises AttributeError.

pd.Series([1, 2], index=['a', 'b']).align(pd.DataFrame([1, 2], index=['a', 'c']))
# AttributeError: 'Series' object has no attribute 'columns'

@sinhrks sinhrks added Bug Indexing Related to indexing on series/frames, not to indexes themselves Compat pandas objects compatability with Numpy or Python functions labels Apr 30, 2016
@sinhrks sinhrks added this to the 0.18.2 milestone Apr 30, 2016
@codecov-io
Copy link

codecov-io commented Apr 30, 2016

Current coverage is 84.07%

Merging #13037 into master will increase coverage by +<.01%

@@             master     #13037   diff @@
==========================================
  Files           136        136          
  Lines         49994      49999     +5   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          42028      42033     +5   
  Misses         7966       7966          
  Partials          0          0          

Powered by Codecov. Last updated by 84725fa...32ced80

@jreback jreback modified the milestones: 0.18.1, 0.18.2 Apr 30, 2016
@jreback jreback closed this in f6a1c41 Apr 30, 2016
@jreback
Copy link
Contributor

jreback commented Apr 30, 2016

thanks @sinhrks

@sinhrks sinhrks deleted the align_subclass branch April 30, 2016 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Compat pandas objects compatability with Numpy or Python functions Indexing Related to indexing on series/frames, not to indexes themselves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFrame align() on a subclassed DataFrame does not invoke _constructor() for the subclassed DataFrame
3 participants