Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: removed pandas.sandbox #13670

Closed
wants to merge 1 commit into from

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Jul 16, 2016

Deprecated back in 0.16.0 here, and the module seems to be rarely, if at all, used according to @jorisvandenbossche .

@codecov-io
Copy link

codecov-io commented Jul 16, 2016

Current coverage is 84.51%

Merging #13670 into master will increase coverage by 0.13%

@@             master     #13670   diff @@
==========================================
  Files           142        141     -1   
  Lines         51223      51142    -81   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43224      43224          
+ Misses         7999       7918    -81   
  Partials          0          0          

Powered by Codecov. Last updated by ada6bf3...5a397a2

@jorisvandenbossche jorisvandenbossche added Deprecate Functionality to remove in pandas QT Clean labels Jul 16, 2016
@jorisvandenbossche jorisvandenbossche added this to the 0.19.0 milestone Jul 16, 2016
@@ -110,78 +110,6 @@ details.
Visualizing Data in Qt applications
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about removing whole section, and moves to ecosystem?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So remove the entire thing about Qt applications? I don't fully understand the second part of your question.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The second part means ecosystem.rst which lists some related projects.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Done.

@gfyoung
Copy link
Member Author

gfyoung commented Jul 16, 2016

@sinhrks : made the requested doc comments (no need to run Travis tests again hence the [ci skip]), so ready to merge if there are no other concerns.

@jreback
Copy link
Contributor

jreback commented Jul 19, 2016

thank you sir!

@gfyoung gfyoung deleted the sandbox-removal branch July 19, 2016 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants