Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: deprecate sortlevel in favor of sort_index #15099

Merged
merged 1 commit into from
Jan 11, 2017

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Jan 10, 2017

closes #14279

@jreback jreback added the Deprecate Functionality to remove in pandas label Jan 10, 2017
@jreback jreback added this to the 0.20.0 milestone Jan 10, 2017
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Minor comment.

Apart from that, should we add a basic sortlevel test that tests that a warning is raised and that it gives the same as sort_index?

@@ -3360,6 +3362,8 @@ def sortlevel(self, level=0, axis=0, ascending=True, inplace=False,
DataFrame.sort_index(level=...)

"""
warnings.warn("sortlevel is deprecated, use sort_index(...)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe 'sort_index(level=...)' to be a bit more specific?

@@ -2006,6 +2008,8 @@ def sortlevel(self, level=0, ascending=True, sort_remaining=True):
Series.sort_index(level=...)

"""
warnings.warn("sortlevel is deprecated, use sort_index(...)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@codecov-io
Copy link

codecov-io commented Jan 10, 2017

Current coverage is 84.75% (diff: 77.77%)

Merging #15099 into master will decrease coverage by <.01%

@@             master     #15099   diff @@
==========================================
  Files           145        145          
  Lines         51220      51220          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          43415      43414     -1   
- Misses         7805       7806     +1   
  Partials          0          0          

Powered by Codecov. Last update c71f214...c070ba8

@jreback
Copy link
Contributor Author

jreback commented Jan 10, 2017

updated

@jorisvandenbossche jorisvandenbossche merged commit b8e7c34 into pandas-dev:master Jan 11, 2017
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 27, 2018
jreback pushed a commit that referenced this pull request Oct 28, 2018
gfyoung added a commit to forking-repos/pandas that referenced this pull request Oct 28, 2018
Was dropped in pandas-devgh-15099 but accidentally added back in pandas-devgh-18202.

Follow-up to pandas-devgh-23375.
jreback pushed a commit that referenced this pull request Oct 28, 2018
Was dropped in gh-15099 but accidentally added back in gh-18202.

Follow-up to gh-23375.
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
tm9k1 pushed a commit to tm9k1/pandas that referenced this pull request Nov 19, 2018
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Pingviinituutti pushed a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEPR: sortlevel
3 participants