Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: replace _interleave_dtype with _find_common_type #15765

Closed
wants to merge 2 commits into from
Closed

CLN: replace _interleave_dtype with _find_common_type #15765

wants to merge 2 commits into from

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Mar 21, 2017

xref #15736
xref #12780

@jreback jreback added Clean Dtype Conversions Unexpected or buggy dtype conversions labels Mar 21, 2017
@jreback jreback added this to the 0.20.0 milestone Mar 21, 2017
@jreback
Copy link
Contributor Author

jreback commented Mar 21, 2017

cc @sdementen

you can rebase on top of this; should make that PR a lot simpler.

@jreback jreback closed this in 1e753d7 Mar 21, 2017
@codecov
Copy link

codecov bot commented Mar 21, 2017 •
edited
Loading

Codecov Report

Merging #15765 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #15765      +/-   ##
==========================================
- Coverage   91.01%   90.99%   -0.03%     
==========================================
  Files         143      143              
  Lines       49395    49371      -24     
==========================================
- Hits        44959    44927      -32     
- Misses       4436     4444       +8
Impacted Files Coverage Δ
pandas/types/cast.py 85.31% <100%> (+0.2%) ⬆️
pandas/core/internals.py 93.62% <100%> (ø) ⬆️
pandas/io/gbq.py 25% <0%> (-58.34%) ⬇️
pandas/core/frame.py 97.86% <0%> (-0.1%) ⬇️
pandas/tseries/index.py 95.29% <0%> (-0.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 783ae69...d472646. Read the comment docs.

@jreback jreback mentioned this pull request Mar 21, 2017
Closed
4 tasks
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
@jreback @AnkurDedania
CLN: replace _interleave_dtype with _find_common_type
fb72afc 
xref pandas-dev#15736   xref pandas-dev#12780

Author: Jeff Reback <jeff@reback.net>

Closes pandas-dev#15765 from jreback/common_types and squashes the following commits:

d472646 [Jeff Reback] try removing restriction on windows
8d07cae [Jeff Reback] CLN: replace _interleave_dtype with _find_common_type
mattip pushed a commit to mattip/pandas that referenced this pull request Apr 3, 2017
@jreback @mattip
CLN: replace _interleave_dtype with _find_common_type
e681a40 
xref pandas-dev#15736   xref pandas-dev#12780

Author: Jeff Reback <jeff@reback.net>

Closes pandas-dev#15765 from jreback/common_types and squashes the following commits:

d472646 [Jeff Reback] try removing restriction on windows
8d07cae [Jeff Reback] CLN: replace _interleave_dtype with _find_common_type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Clean Dtype Conversions Unexpected or buggy dtype conversions
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jreback