Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper checks on nrows and chunksize for read_csv #15767

Closed
toobaz opened this issue Mar 21, 2017 · 0 comments · Fixed by #15774
Closed

Proper checks on nrows and chunksize for read_csv #15767

toobaz opened this issue Mar 21, 2017 · 0 comments · Fixed by #15774
Labels
API Design Error Reporting Incorrect or improved errors from pandas IO CSV read_csv, to_csv
Milestone

Comments

@toobaz
Copy link
Member

toobaz commented Mar 21, 2017

From #15755 (e.g. this comment).

Current status:

  • there is a check on nrows, which ensure floats are converted to int with no loss of precision, but not that the resulting/passed value is non-negative
  • there is no check on chunksize, so that a pd.concat based on chunksize=0 will enter an infinite loop

I guess we want to ensure chunksize > 0 and nrows >= 0.

@chris-b1 chris-b1 added IO CSV read_csv, to_csv API Design labels Mar 21, 2017
@jreback jreback added Difficulty Novice Error Reporting Incorrect or improved errors from pandas labels Mar 21, 2017
@jreback jreback added this to the Next Major Release milestone Mar 21, 2017
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, Next Major Release Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Design Error Reporting Incorrect or improved errors from pandas IO CSV read_csv, to_csv
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants