Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatetimeIndex comparison tzaware vs naive should raise #18162

Closed
jbrockmendel opened this issue Nov 8, 2017 · 1 comment · Fixed by #18376
Closed

DatetimeIndex comparison tzaware vs naive should raise #18162

jbrockmendel opened this issue Nov 8, 2017 · 1 comment · Fixed by #18376
Labels
Bug Timezones Timezone data dtype
Milestone
0.23.0

Comments

@jbrockmendel
Copy link
Member 

>>> dr = pd.date_range('2016-01-01', periods=6)
>>> dz = dr.tz_localize('US/Pacific')
>>> dr < dz
array([ True,  True,  True,  True,  True,  True], dtype=bool)
>>> dr[0] < dz[0]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "pandas/_libs/tslib.pyx", line 1169, in pandas._libs.tslib._Timestamp.__richcmp__
  File "pandas/_libs/tslib.pyx", line 1230, in pandas._libs.tslib._Timestamp._assert_tzawareness_compat
TypeError: Cannot compare tz-naive and tz-aware timestamps

The vectorized comparison should raise too right?
@jreback
Copy link
Contributor

jreback commented Nov 8, 2017

yes this should raise

@jreback jreback added this to the Next Major Release milestone Nov 8, 2017
This was referenced Nov 20, 2017
Merged
Closed
@jreback jreback modified the milestones: Next Major Release, 0.22.0 Dec 12, 2017
@jbrockmendel jbrockmendel mentioned this issue Jan 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Timezones Timezone data dtype
Projects
None yet
Milestone
0.23.0
Development

Successfully merging a pull request may close this issue.

implement assert_tzawareness_compat for DatetimeIndex jbrockmendel/pandas
2 participants
@jreback @jbrockmendel