Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Series.get_values() #18474

Closed
jreback opened this issue Nov 24, 2017 · 3 comments
Closed

DEPR: Series.get_values() #18474

jreback opened this issue Nov 24, 2017 · 3 comments
Labels
Deprecate Functionality to remove in pandas
Milestone

Comments

@jreback
Copy link
Contributor

jreback commented Nov 24, 2017

this was never meant to be exposed to the user, is not-documented, and is just plain confusing

@jreback jreback added Deprecate Functionality to remove in pandas Difficulty Intermediate labels Nov 24, 2017
@jreback jreback added this to the 0.22.0 milestone Nov 24, 2017
@WillAyd
Copy link
Member

WillAyd commented Apr 18, 2018

Hmm I think this has some pretty far reaching impacts as it's used internally below:

f = getattr(o, 'get_values', None)

I suppose we could add some type of introspection there specific to Series but do you see this spilling over into other classes at some point as well?

@jreback jreback modified the milestones: 0.23.0, 0.24.0 Apr 24, 2018
@jreback
Copy link
Contributor Author

jreback commented Apr 24, 2018

no, want to completely remove this in favor of using _ndarray_values and .values as appropriate. too many ways of doing things. this will be easier once Sparse is an extension array.

@jreback
Copy link
Contributor Author

jreback commented Oct 23, 2018

duplicate of #19617

@jreback jreback closed this as completed Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas
Projects
None yet
Development

No branches or pull requests

2 participants