Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asv tests for DataFrame constructor #18840

Closed
toobaz opened this issue Dec 19, 2017 · 3 comments
Closed

asv tests for DataFrame constructor #18840

toobaz opened this issue Dec 19, 2017 · 3 comments
Labels
Benchmark Performance (ASV) benchmarks good first issue

Comments

@toobaz
Copy link
Member

toobaz commented Dec 19, 2017

After #18769 , the asv coverage of different possibilities of initialization values for Series() should be pretty good (see asv_bench/benchmarks/ctors.py ).

The coverage for DataFrame instead (see asv_bench/benchmarks/frame_ctor.py) is more limited and should be expanded.
@toobaz toobaz mentioned this issue Dec 19, 2017
Merged
2 tasks
@jreback jreback added the Benchmark Performance (ASV) benchmarks label Dec 19, 2017
@jreback jreback added this to the 0.22.0 milestone Dec 19, 2017
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.23.0, Next Major Release Mar 29, 2018
@moisesjsanchez
Copy link

Hello, I am a first-time contributor. If this issue is still open would it be okay for me to work on this?

@WillAyd
Copy link
Member

WillAyd commented Oct 4, 2019

@moisesjsanchez sure!

@jbrockmendel
Copy link
Member

Closing as completed (albeit ongoing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Benchmark Performance (ASV) benchmarks good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@WillAyd @jreback @jorisvandenbossche @toobaz @jbrockmendel @moisesjsanchez