Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Refactor nanops' empty array handling #18976

Open
TomAugspurger opened this issue Dec 28, 2017 · 0 comments
Open

CLN: Refactor nanops' empty array handling #18976

TomAugspurger opened this issue Dec 28, 2017 · 0 comments
Labels
Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Reduction Operations sum, mean, min, max, etc. Refactor Internal refactoring of code

Comments

@TomAugspurger
Copy link
Contributor

In

pandas/pandas/core/nanops.py

Line 110 in e1d5a27

if values.size == 0 and kwds.get('min_count') is None:

It'd be better to remove that block and just have each of the nan* methods correctly handle empty arrays on their own.
@TomAugspurger TomAugspurger added Difficulty Intermediate Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Numeric Operations Arithmetic, Comparison, and Logical operations labels Dec 28, 2017
@TomAugspurger TomAugspurger added this to the Next Major Release milestone Dec 28, 2017
@mroeschke mroeschke added the Refactor Internal refactoring of code label Jun 12, 2021
@mroeschke mroeschke removed this from the Contributions Welcome milestone Oct 13, 2022
@jbrockmendel jbrockmendel added Reduction Operations sum, mean, min, max, etc. and removed Numeric Operations Arithmetic, Comparison, and Logical operations labels Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Missing-data np.nan, pd.NaT, pd.NA, dropna, isnull, interpolate Reduction Operations sum, mean, min, max, etc. Refactor Internal refactoring of code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TomAugspurger @jbrockmendel @mroeschke