Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scripts/convert_deps.py doesn't handle exact pins correctly #22689

Closed
TomAugspurger opened this issue Sep 13, 2018 · 2 comments
Closed

scripts/convert_deps.py doesn't handle exact pins correctly #22689

TomAugspurger opened this issue Sep 13, 2018 · 2 comments

Comments

@TomAugspurger
Copy link
Contributor

This should be a double equals:

pandas/ci/requirements-optional-pip.txt

Line 17 in 857515f

openpyxl=2.5.5

conda uses a single, while pip requirements files use double.
@TomAugspurger TomAugspurger mentioned this issue Sep 13, 2018
Merged
4 tasks
@mroeschke
Copy link
Member

Since all the refactoring of the scrips, is this still an issue?

@TomAugspurger
Copy link
Contributor Author

Yeah, I think it's been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TomAugspurger @mroeschke